Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean variable to the ACCESS Live CMORiser #2601

Open
wants to merge 103 commits into
base: main
Choose a base branch
from

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Dec 2, 2024

Description

Adds Ocean variable to the ACCESS Live CMORIser


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@rhaegar325
Copy link
Contributor

Hi, @valeriupredoi @schlunma , really appreciate for your suggestion about our pr, that's really helpful. Now we have solved all the issues and this pr is ready to be reviewed and merged. Please review it when it's convenient for you. Thanks again for all the suggestions and help.

@rbeucher
Copy link
Contributor Author

rbeucher commented Mar 3, 2025

@charles-turner-1 do you think you can review that one for us please?

Copy link

@charles-turner-1 charles-turner-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thing related to numpy arrays that I think would be useful to change for performance/readability.

Otherwise looks good - although I don't know enough about the logic of the CMORIsers so my opinion isn't worth much there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants