Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMIP5 MRI-ESM1 grid #2670

Closed
wants to merge 1 commit into from
Closed

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Feb 20, 2025

Description

Replace the rotated pole coordinates by index coordinates for CMIP5 MRI-ESM1 fgco2
to avoid the regridder picking up the wrong grid.

See ESMValGroup/ESMValTool#3916 (comment) and ESMValGroup/ESMValTool#3916 (comment)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (06ce74d) to head (6b1695a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2670   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         255      255           
  Lines       14900    14921   +21     
=======================================
+ Hits        14168    14188   +20     
- Misses        732      733    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela changed the title Fix CMIP5 MRI-ESM1 fgco2 grid Fix CMIP5 MRI-ESM1 and inmcm4 grid Feb 20, 2025
@bouweandela bouweandela changed the title Fix CMIP5 MRI-ESM1 and inmcm4 grid Fix CMIP5 MRI-ESM1 grid Feb 20, 2025
@bouweandela
Copy link
Member Author

This may not be necessary if #2672 works out.

@bouweandela bouweandela deleted the fix-cmip5-mri-esm1-fgco2-grid branch February 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant