Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general model evaluation recipes (for Changelog: authors: @axel-lauer, @hb326, @Paulinebonnet111, @LisaBock, @schlunma) #3421

Merged
merged 34 commits into from
Nov 30, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 14, 2023

Description

This PR adds a collection of general model evaluation recipes. All of these are based on the monitoring diagnostics. Theses recipes have been developed as part of a DLR workshop on developing diagnostics and recipes for the evaluation of our own ICON simulations. This PR provides these recipes for the community (the non-publicly available ICON data has been replaced by CMIP6 data for this).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

axel-lauer and others added 28 commits September 5, 2023 15:07
Create icon folder within the recipe folder.
small change in the diagnostic for bug solving
Added Pauline as an author.
@schlunma schlunma added this to the v2.11.0 milestone Nov 14, 2023
@schlunma schlunma self-assigned this Nov 14, 2023
Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the recipes and they run fine. The output looks fine even though the automatic scaling of e.g. the color bars is sometimes not optimum.

Please take a look at a few suggestions of how to phrase things I had.

doc/sphinx/source/faq.rst Outdated Show resolved Hide resolved
doc/sphinx/source/faq.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_model_evaluation.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_model_evaluation.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_model_evaluation.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_model_evaluation.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_model_evaluation.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @schlunma!!

@hb326 hb326 merged commit 82e7f39 into main Nov 30, 2023
6 checks passed
@hb326 hb326 deleted the model_eval_recipes branch November 30, 2023 12:24
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
…auer, @hb326, @Paulinebonnet111, @LisaBock, @schlunma) (#3421)

Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
Co-authored-by: Pauline Bonnet <b309216@levante0.lvt.dkrz.de>
Co-authored-by: Birgit Hassler <33543691+hb326@users.noreply.github.com>
Co-authored-by: Birgit Hassler <birgit.hassler@dlr.de>
Co-authored-by: Paulinebonnet111 <123577048+Paulinebonnet111@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write basic evaluation recipe
4 participants