-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general model evaluation recipes (for Changelog: authors: @axel-lauer, @hb326, @Paulinebonnet111, @LisaBock, @schlunma) #3421
Conversation
Create icon folder within the recipe folder.
small change in the diagnostic for bug solving
Added Pauline as an author.
…apandprofileplots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested the recipes and they run fine. The output looks fine even though the automatic scaling of e.g. the color bars is sometimes not optimum.
Please take a look at a few suggestions of how to phrase things I had.
esmvaltool/recipes/model_evaluation/recipe_model_evaluation_basics.yml
Outdated
Show resolved
Hide resolved
esmvaltool/recipes/model_evaluation/recipe_model_evaluation_clouds_cycles.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @schlunma!!
…auer, @hb326, @Paulinebonnet111, @LisaBock, @schlunma) (#3421) Co-authored-by: Axel Lauer <axel.lauer@dlr.de> Co-authored-by: Pauline Bonnet <b309216@levante0.lvt.dkrz.de> Co-authored-by: Birgit Hassler <33543691+hb326@users.noreply.github.com> Co-authored-by: Birgit Hassler <birgit.hassler@dlr.de> Co-authored-by: Paulinebonnet111 <123577048+Paulinebonnet111@users.noreply.github.com>
Description
This PR adds a collection of general model evaluation recipes. All of these are based on the monitoring diagnostics. Theses recipes have been developed as part of a DLR workshop on developing diagnostics and recipes for the evaluation of our own ICON simulations. This PR provides these recipes for the community (the non-publicly available ICON data has been replaced by CMIP6 data for this).
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: