-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Basic Tutorial Episodes for compatibility with v2.10.0 #317
Conversation
@LisaBock - Please review when possible. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ranjini! Depart a small comment everything seems fine.
Fortunately there were not many changes needed.
_episodes/04-recipe.md
Outdated
@@ -368,7 +368,7 @@ Do you recognize the basic recipe structure that was introduced in episode 1? | |||
> > which contains preprocessed data for each of the input datasets, plus a | |||
> > combined `MultiModelMean`, a `metadata.yml` file and provenance files. | |||
> > - **map/script1**: creates `/run/map/script1` with general information and a | |||
> > log of the diagnostic script run. It also creates `/plots/map/script1` and | |||
> > log of the diagnostic script run. It also creates `/plots/map/script1/png` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like to add the png subfolder, you should add that as well for the timeseries plots folder below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think I will leave this out. That way it is consistent for png and other file types too. Thanks!
Thanks @LisaBock for the quick review. |
…cs_to_v2.10.0 Update Basic Tutorial Episodes for compatibility with v2.10.0
Pull Request checklist
We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.
Before you start
Tasks
Lesson development
section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.Lesson organization
andLesson formatting
sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.make serve
, alternativelymake docker-serve
. Please see thePreviewing your changes locally
section in CONTRIBUTING.md for installation instructions.If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes 316