Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Basic Tutorial Episodes for compatibility with v2.10.0 #317

Merged
merged 7 commits into from
May 16, 2024

Conversation

rswamina
Copy link
Contributor

@rswamina rswamina commented May 14, 2024

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • [ x] Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes 316

@rswamina rswamina self-assigned this May 14, 2024
@rswamina rswamina requested a review from LisaBock May 15, 2024 10:46
@rswamina rswamina marked this pull request as ready for review May 15, 2024 10:47
@rswamina
Copy link
Contributor Author

@LisaBock - Please review when possible. Thanks!

Copy link
Contributor

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ranjini! Depart a small comment everything seems fine.

Fortunately there were not many changes needed.

@@ -368,7 +368,7 @@ Do you recognize the basic recipe structure that was introduced in episode 1?
> > which contains preprocessed data for each of the input datasets, plus a
> > combined `MultiModelMean`, a `metadata.yml` file and provenance files.
> > - **map/script1**: creates `/run/map/script1` with general information and a
> > log of the diagnostic script run. It also creates `/plots/map/script1` and
> > log of the diagnostic script run. It also creates `/plots/map/script1/png` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like to add the png subfolder, you should add that as well for the timeseries plots folder below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think I will leave this out. That way it is consistent for png and other file types too. Thanks!

@rswamina
Copy link
Contributor Author

Thanks @LisaBock for the quick review.
All checks have passed and reviewer comments addressed so changes will be merged.

@rswamina rswamina merged commit ce536fd into main May 16, 2024
1 check passed
@rswamina rswamina deleted the update_basic_topics_to_v2.10.0 branch May 16, 2024 11:58
ehogan pushed a commit to ehogan/ESMValTool_Tutorial that referenced this pull request Nov 21, 2024
…cs_to_v2.10.0

Update Basic Tutorial Episodes for compatibility with v2.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Basic Tutorial episodes for compatibility with v2.10.0
2 participants