Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on cert errors #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Continue on cert errors #164

wants to merge 2 commits into from

Conversation

painter1
Copy link
Contributor

@painter1 painter1 commented Mar 3, 2021

This is a replacement for pull request 145, issued in May 2020. It does the same thing, but request 145 was compatible with the master branch in May, and this is compatible with the current master branch. If the master branch changes again, I will not redo this request.

The purpose of this patch is to allow use of Synda when a identity server is down, unable to renew certificates; but the existing certificates are still valid. In this case, Synda can and should continue to work normally - with rare exceptions when a certificate has actually expired.

If the user does nothing, then there is no change from the present behavior of Synda.
But if the user sets "continue_on_cert_errors=true" in the download section of his configuration file, then certificate errors will be essentially ignored. Specifically, when sddmdefault.transfers_begin() encounters an exception while renewing a certificate, then it will simply continue.

This small change is essential to production-scale operation of Synda for replication, and prevents an occasional confusing error for all uses of Synda. The reason for requiring a setting in the configuration file is that there is a certain small risk, and the user should be aware of it.

Usually it works.  This feature is disabled by default, but the user
can turn it on by setting "continue_on_cert_errrors=true" in the download
section of the configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant