Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart failed url and survive duplicate files #171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Restart failed url and survive duplicate files #171

wants to merge 4 commits into from

Conversation

painter1
Copy link
Contributor

There are two changes here, submitted together because they both involve sdsqlutils.py.

  1. Upon a retry, the failed_url table should be cleared for the retried files. Otherwise they can't be properly retried.
  2. On rare occasions I have seen Synda crash due to duplicate database entries for the same file or similar problems which aren't supposed to happen. This change deals with them by logging an error message, changing a filename, and assigning a special status. Clearing up the problem has to be done manually, but with this change it is not urgent.

@painter1
1. When a file is retried, delete any appearances in the failed_url t…
d2638a4 
…able.

2. In sdsqlutils.insert(), do not crash if sqlite3 raises an IntegrityError.
For example, this can happen if the same file is in two places.  Instead of
a crash, log the event and change the filename.  The database will have to be
fixed manually.
@painter1
An IntegrityError should be logged with sdlog.error, not sdlog.info.
1e2845f
@painter1
Define a special error status for path-related errors. Presently, Syn…
933df9c 
…da can

sometimes detect them but cannot fix them.
@painter1
Fix minor bug found during testing.
03f51bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@painter1