Skip to content

Commit

Permalink
Fix compilation of py::bind_vector for VS 15.9.x
Browse files Browse the repository at this point in the history
The newer VS compiler version are giving compile errors for py::bind_vector. The fix is based on pybind/pybind11#1616 (comment)
  • Loading branch information
arthursoprana committed Jan 22, 2019
1 parent 5eb4bcd commit fb76d5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hookman/hookman_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def _hook_caller_python_content(self) -> str:
for index, (r_type, args_type) in enumerate(sorted(signatures)):
name = f'vector_hook_impl_type_{index}'
vector_type = f"std::vector<std::function<{r_type}({args_type})>>"
content_lines.append(f' py::bind_vector<{vector_type}>(m, "{name}");')
content_lines.append(f' py::bind_vector<{vector_type}>(m, "{name}", "Hook for vector implementation type {index}");')
content_lines.append("")

content_lines += [
Expand Down

0 comments on commit fb76d5b

Please sign in to comment.