Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty lines in replay files #70

Closed
DavideCanton opened this issue Nov 15, 2024 · 3 comments · Fixed by #71
Closed

Ignore empty lines in replay files #70

DavideCanton opened this issue Nov 15, 2024 · 3 comments · Fixed by #71

Comments

@DavideCanton
Copy link
Contributor

When cutting/pasting stuff around in the replay files, lines can be commented out, but if some blank line is added, the run errors. I suspect this is because the code always does a json.loads if the line is not a comment.

What about skipping empty lines along with commented ones?
@nicoddemus
Copy link
Member

Sounds reasonable. 👍

@DavideCanton
Copy link
Contributor Author

I can submit a PR in these days

DavideCanton added a commit to DavideCanton/pytest-replay that referenced this issue Nov 23, 2024
@DavideCanton
Ignored empty and blank lines in replay file (ESSS#70)
1b53a6c
@DavideCanton DavideCanton mentioned this issue Nov 23, 2024
Merged
@nicoddemus
Copy link
Member

1.5.3 released with this fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignored empty and blank lines in replay file (#70) DavideCanton/pytest-replay
2 participants
@nicoddemus @DavideCanton