Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply review comments #18

Merged

Conversation

denStrigo
Copy link

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

@@ -1,9 +1,10 @@
import { Component } from '@angular/core';
import {Component} from '@angular/core';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add spaces

@@ -19,7 +19,7 @@ export class TrafficRevealCardComponent implements OnDestroy {
private alive = true;

// TODO: move to service
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use service now?

@ESadouski ESadouski merged commit 82e78a7 into ESadouski:ecommerce-dashboard Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants