Fix bug #636 in optional emplace for pod types (#638)

ETLCPP · Nov 23, 2022 · 82c2f8a · 82c2f8a
1 parent 3623ba5
commit 82c2f8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/include/etl/optional.h b/include/etl/optional.h
@@ -764,12 +764,6 @@ namespace etl
     template <typename ... Args>
     ETL_CONSTEXPR14 void emplace(Args && ... args)
     {
-      if (valid)
-      {
-        // Destroy the old one.
-        storage.template get_reference<T>().~T();
-      }
-
       storage = T(ETL_OR_STD::forward<Args>(args)...);
       valid = true;
     }

diff --git a/test/test_optional.cpp b/test/test_optional.cpp
@@ -484,5 +484,15 @@ namespace
 
       CHECK_EQUAL(false, result.has_value());
     }
+
+    //*************************************************************************
+    TEST(test_optional_emplace_bug_636)
+    {
+      etl::optional<std::uint8_t> result = 1;
+      result.emplace(2);
+
+      CHECK_TRUE(result.has_value());
+      CHECK_EQUAL(2, result.value());
+    }
   };
 }