[WIP] implementation of templated timer tick #943
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #941
Opening this now before continuing with the other timer services because I feel the approach is perhaps breaking too many things.
This adds
timer_model.h
(name up to change, just wanted to keep it aligned with memory model) that is then used to determine the appropriate type for the ticker, to not limit the resolution to 32bits. I implemented this only formessage_timer.h
as a proof of concept but the concept can be applied to the rest of the servicesThe main issue I have with this approach, is that it requires templating
timer
sinceinterval
andstate
depend onTIMER_MODEL
. I couldn't find a way to abstract this without some major refactoring and without not templatingtimer
. If this is a breaking change and there are no proposed alternative and more elegant solutions I'm missing, feel free to reject and close this PROtherwise, I can work on cleaning this up and working on the rest of the timers