Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that pip install dist custom target does not run every time #7

Conversation

hikinggrass
Copy link
Contributor

No description provided.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass requested a review from andistorm June 26, 2024 10:13
Copy link

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a comment on further improvements we can do here. I'll leave the decision up to you and approve the changes you already made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same fix could be done in function ev_create_pip_install_local_target.

In function ev_create_python_wheel_targets we generate files which could be set as OUTPUT file, but not sure how to get the name of the wheel file, and also not sure what best practice whould be for the kind of custom install target ${EV_CREATE_PYTHON_WHEEL_TARGETS_PACKAGE_NAME}_install_wheel

@hikinggrass hikinggrass merged commit d8d5e37 into main Jun 26, 2024
2 checks passed
@hikinggrass hikinggrass deleted the bugfix/prevent-pip-install-custom-target-from-running-every-time branch June 26, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants