Skip to content

Commit

Permalink
remove todos
Browse files Browse the repository at this point in the history
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
  • Loading branch information
andistorm committed Oct 30, 2024
1 parent c0d0fa9 commit fa5d8a2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .ci/build-kit/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
ARG BASE_IMAGE_TAG=latest
FROM ghcr.io/everest/everest-ci/build-kit-base:${BASE_IMAGE_TAG}

# LTODO temp
# Should be removed after updating the base image
ENV EVEREST_CMAKE_PATH=/usr/lib/cmake/everest-cmake
ENV EVEREST_CMAKE_VERSION=bugfix/setup-cmake-variables-python-wheel
ENV EVEREST_CMAKE_VERSION=v0.5.0
RUN rm -rf ${EVEREST_CMAKE_PATH} \

Check warning on line 8 in .ci/build-kit/docker/Dockerfile

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

.ci/build-kit/docker/Dockerfile#L8

Use WORKDIR to switch to a directory
&& git clone https://github.com/EVerest/everest-cmake.git ${EVEREST_CMAKE_PATH} \
&& cd ${EVEREST_CMAKE_PATH} \
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ on:
jobs:
ci:
name: Build, Lint and Test
# LTODO - set to tag
uses: everest/everest-ci/.github/workflows/continuous_integration.yml@bugfix/build-kit-in-forks
uses: everest/everest-ci/.github/workflows/continuous_integration.yml@v1.4.0
permissions:
contents: read
secrets:
Expand Down

0 comments on commit fa5d8a2

Please sign in to comment.