-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forced unlocking #542
Fix forced unlocking #542
Conversation
Thanks for addressing this issue. We also noticed this on Tarragon, but thought this was an issue in our BSP implementation. Nevertheless i like to leave some comment regarding the implementation. From our understanding this command is the last resort for the EV driver who isn't able to get his cable back. So "force" should be considered as almost "unconditional", which from our understanding means always unlock the plug lock no matter what the CP state says. Since we cannot trust the mechanics of the plug lock and its sensors or the cable. The only exception should be that the EVSE contactor is closed. In case this change is too big for this regression, i can open a new issue here. |
478e634
to
cef0644
Compare
It is just a one line change to support state C as well. Agreed that probably it is better to only forbid a force_unlock if the relais are closed as state C is beyond our control on the EVSE side. |
Now force_unlock remains active until it is "normally" unlocked because state A/E/F is reached. Unlocking happens whenever relais are open and it is either force_unlocked or normally unlocked. It needs some testing still. |
Thanks, i will try to discuss this within our team so we can test this soon. |
Tested on one HW now |
a866734
to
e0ebd57
Compare
Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
e0ebd57
to
6e01d2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Force unlocking was not working after the bsp refactoring. This PR fixes force unlocking in state B. Force unlocking in state C is not supported.