Doc/powermeter error handling #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florinmihut
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
a-w50
reviewed
Aug 30, 2024
| } else { | ||
| EVLOG_info << "LEM DCBM 400/600: The last known transaction has the id:" << this->current_transaction_id; | ||
| } | ||
| } catch (json::exception& json_error) { |
There was a problem hiding this comment.
catch const ref, i.e. const json::exception& json_error)
doc/error_case.puml
Outdated
Comment on lines
1
to
16
| @startuml | ||
| actor User | ||
| participant Powermeter | ||
| participant Error_Manager | ||
| participant EVSE_Manager | ||
| participant OCPP | ||
|
|
||
| User -> EVSE_Manager: startChargingSession | ||
| alt successful case | ||
| EVSE_Manager -> Powermeter: startTransaction | ||
| Powermeter -> EVSE_Manager: startTransaction Response (OK/ID) | ||
| EVSE_Manager -> OCPP: persistTransaction (ID) | ||
| else startTransaction failing due to power loss | ||
| EVSE_Manager -> Powermeter: startTransaction | ||
| Powermeter -> EVSE_Manager: startTransaction Response (FAIL) | ||
| EVSE_Manager -> User: stopChargingSession |
There was a problem hiding this comment.
really nice that you've created these puml files, maybe we should come up with a guideline, whether rendered versions (jpeg, png) should be created - because it is quite some work to manually create a picture out of it
corneliusclaussen
force-pushed
the
doc/powermeter_error_handling
branch
from
9ca144a to
1ecf197
Compare
…entical to init. Subsequent StopTransactions will be handled correctly since we know if a transaction is open or not Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
…er and OCPP covering handling of OCMF/Eichrecht Signed-off-by: pietfried <pietgoempel@gmail.com>
Signed-off-by: pietfried <pietgoempel@gmail.com>
corneliusclaussen
force-pushed
the
doc/powermeter_error_handling
branch
from
d5def77 to
60c75b5
Compare
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
barsnick
requested changes
Jan 2, 2025
Co-authored-by: barsnick <barsnick@users.noreply.github.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
Co-authored-by: barsnick <barsnick@users.noreply.github.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
3 tasks
Pietfried
reviewed
Jan 6, 2025
| EvseManager->>Powermeter: startTransaction | ||
| Powermeter-->>EvseManager: startTransaction Response (FAIL) | ||
|
|
||
| EvseManager->>OCPP: Event(Deauthorized) |
There was a problem hiding this comment.
Please see my comment here which would change this flow.
#993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review