Power supply off: send cablecheck as phase if switching off after suc… #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
corneliusclaussen
force-pushed
the
bugfix/cablecheckphase
branch
from
c5231d2 to
14d6f6e
Compare
corneliusclaussen
force-pushed
the
bugfix/cablecheckphase
branch
from
14d6f6e to
22a30ed
Compare
…cess Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
corneliusclaussen
force-pushed
the
bugfix/cablecheckphase
branch
from
22a30ed to
ef00320
Compare
hikinggrass
pushed a commit
that referenced
this pull request
Nov 21, 2024
#907) * Power supply off: send cablecheck as phase if switching off after success Signed-off-by: Cornelius Claussen <cc@pionix.de> * clang-format Signed-off-by: Cornelius Claussen <cc@pionix.de> --------- Signed-off-by: Cornelius Claussen <cc@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cess
Describe your changes
Some power supplies need to know the difference between normal "Off" and the Off between CableCheck and PreCharge. This PR sets the correct reason when cable check fails.
Issue ticket number and link
Checklist before requesting a review