Adding tls key logger for EvseV2G (openssl part) #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
corneliusclaussen,
james-ctc,
AssemblyJohn,
Pietfried and
hikinggrass
as code owners
james-ctc
requested changes
Oct 15, 2024
james-ctc
approved these changes
Oct 22, 2024
SebaLukas
force-pushed
the
feat/adding-openssl-tls-key-logger
branch
2 times, most recently
from
6b2aa03 to
2b04105
Compare
hikinggrass
approved these changes
Oct 24, 2024
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
…or the keylog file path and tls key server Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
common error handling on error (removed early return) Signed-off-by: James Chapman <james.chapman@pionix.de>
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
SebaLukas
force-pushed
the
feat/adding-openssl-tls-key-logger
branch
from
2b04105 to
edada6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Right now only the EvseV2G mbedtls side had the functionality to store the tls session key. Now if you build EvseV2G with openssl, you can store the tls session key, too. For debugging pcap files with a tls connection this key is absolutely necessary.
Issue ticket number and link
#857
Checklist before requesting a review