feat: add support for new EVSE security API #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
force-pushed
the
feat/trusted-ca-keys-update
branch
2 times, most recently
from
04845bb to
ff11f8b
Compare
dorezyuk
reviewed
Oct 19, 2024
AssemblyJohn
force-pushed
the
feature/multi_root_trusted_ca
branch
2 times, most recently
from
2f48af0 to
a108226
Compare
Now uses call_get_all_valid_certificates_info() to obtain multiple server certificate chains in order to support trusted_ca_keys. Signed-off-by: James Chapman <james.chapman@pionix.de>
james-ctc
force-pushed
the
feat/trusted-ca-keys-update
branch
from
ff11f8b to
f00202b
Compare
|
The integration looks fine to me, all good! |
james-ctc
requested review from
corneliusclaussen,
SebaLukas and
AssemblyJohn
as code owners
AssemblyJohn
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now uses call_get_all_valid_certificates_info() to obtain multiple server certificate chains in order to support trusted_ca_keys.
Issue ticket number and link
Checklist before requesting a review