EvseV2G/IsoMux: check if if_name is nullptr #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
requested review from
corneliusclaussen,
SebaLukas,
james-ctc and
Pietfried
as code owners
SebaLukas
reviewed
Oct 22, 2024
| @@ -112,6 +112,10 @@ int check_interface(struct v2g_context* v2g_ctx) { | |||
| v2g_ctx->if_name = choose_first_ipv6_interface(); | |||
| } | |||
|
|
|||
| if (v2g_ctx->if_name == nullptr) { | |||
There was a problem hiding this comment.
In line 125 there is already a check if if_name == nulltpr. So the segfault is happening in line 119 (mreq.ipv6mr_interface = if_nametoindex(v2g_ctx->if_name);) ?
james-ctc
requested changes
Oct 22, 2024
SebaLukas
approved these changes
Oct 22, 2024
This can happen if there are no interfaces with IPv6 addresses and would lead to a segfault later on Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
corneliusclaussen
force-pushed
the
bugfix/check-if_name-for-nullptr
branch
from
6c56e7d
to
82c617d
Compare
Pietfried
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if there are no interfaces with IPv6 addresses and would lead to a segfault later on
Describe your changes
Issue ticket number and link
Checklist before requesting a review