Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date: adjust flags to not use remote #211

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

dorezyuk
Copy link
Contributor

@dorezyuk dorezyuk commented Oct 18, 2024

Fixes the compilation flags for the date library
The flags were not the same as for the cmake/yocto toolchains

@dorezyuk dorezyuk force-pushed the feat/adjust_date_flags branch from 56b491a to bf7f07c Compare October 18, 2024 08:10
@dorezyuk dorezyuk marked this pull request as draft October 18, 2024 13:00
Signed-off-by: Dima Dorezyuk <ddo@qwello.eu>
@dorezyuk dorezyuk force-pushed the feat/adjust_date_flags branch from bf7f07c to c5a21c0 Compare October 18, 2024 14:08
@dorezyuk dorezyuk marked this pull request as ready for review October 22, 2024 08:11
@hikinggrass
Copy link
Contributor

hikinggrass commented Oct 22, 2024

[...] The flags are not the same as for the cmake/yocto toolchains

Why are they different?

@dorezyuk
Copy link
Contributor Author

Why are they different?

it should be past tense - they were different and this commit fixes that

@hikinggrass hikinggrass changed the title Data: adjust flags to not use remote Date: adjust flags to not use remote Oct 22, 2024
@hikinggrass hikinggrass merged commit db20357 into EVerest:main Oct 22, 2024
5 checks passed
hikinggrass pushed a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Dima Dorezyuk <ddo@qwello.eu>
Co-authored-by: Dima Dorezyuk <ddo@qwello.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants