bug: correct read behavior #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ReadResult read(uint8_t* buf, size_t len)` function should always set the `would_block` property of the `ReadResult` to true, if it reads less bytes then requested. Otherwise, the caller might assume that the requested bytes have been read. The implementation of the ConnectionPlain class didn't respect this contract and hence yielded a bug, as the caller assumed the bytes were completely read. Signed-off-by: aw <aw@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReadResult read(uint8_t* buf, size_t len)function should always set thewould_blockproperty of theReadResultto true, if it reads less bytes then requested. Otherwise, the caller might assume that the requested bytes have been read.The implementation of the ConnectionPlain class didn't respect this contract and hence yielded a bug, as the caller assumed the bytes were completely read.
Describe your changes
Issue ticket number and link
Checklist before requesting a review