Code coverage improvements. #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
|
TODO: add correct dependency to everest utils as well (also in everest core???) |
maaikez
force-pushed
the
feature/coverage_improvements
branch
2 times, most recently
from
86e094c to
717200e
Compare
4 tasks
hikinggrass
requested changes
Jan 20, 2025
lib/CMakeLists.txt
Outdated
| @@ -191,3 +191,5 @@ endif() | |||
| # with gcc 10.x and C++11/14, so we need to publish the | |||
| # C++17 standard | |||
| target_compile_features(ocpp PUBLIC cxx_std_17) | |||
| append_coverage_compiler_flags_to_target(ocpp) | |||
There was a problem hiding this comment.
you can do this in tests/CMakeLists.txt so these flags don't get added even if you don't want to have coverage enabled
hikinggrass
reviewed
Jan 29, 2025
tests/CMakeLists.txt
Outdated
| message("The \"ev-dev-tools\" Python3 package is not installed. You can install it going to | ||
| `everest-utils/ev-dev-tools` and type `pip install .`") | ||
| else() | ||
| add_custom_target(cleanup_coverage |
There was a problem hiding this comment.
add a flag so you can disable this
…obally). Run script to remove gcda files and orphaned object / gcno files (useful after switching branches) Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/coverage_improvements
branch
from
018dea7 to
0a91a3e
Compare
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/coverage_improvements
branch
from
0a91a3e to
6c60b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Append coverage compiler flags only to specific target (instead of globally). Run script to remove gcda files and orphaned object / gcno files (useful after switching branches)
Issue ticket number and link
Checklist before requesting a review