[MNT]: 2019.1.0rc2 prep

[asreimer]

Housekeeping. Bumping version numbers, updating valid resen-cores, etc.

[asreimer]

Waiting for #31 then will review codebase and head towards release.

[pmreyes2]

I'll test this.

...adding core...
...adding mounts...
Bucket created successfully!
Pulling image: 2019.1.0rc2
   This may take some time...
[==================================================>] 100.00 %, 2.667/2.67GB Elapsed time: 0:02:10
Done!
...starting jupyterlab...
ERROR: Failed to start jupyter server!
[resen] >>>

The docker container is running, and the patched file:
/home/jovyan/envs/py36/lib/python3.6/site-packages/notebook/notebookapp.py looks good

and I have no problems starting a jupyter lab from a terminal in the container:
docker exec -it --user jovyan resen_b0 bash
Only thing strange is that it brings me to / instead of /home/jovyan

• Besides kernels py27 and py36, kernel python3 still shows as an option in jupyter, but it is essentially py36.

Tested on mac and on ubuntu server:
As a test, I added both rc1 and rc2 to the resen tool, so:
Available versions: 2019.1.0rc1, 2019.1.0rc2
Created buckets with both versions. 2019.1.0rc1 starts/stops(fixing notebookapp.py manually) jupyter fine, but starting a bucket with image 2019.1.0rc2 fails to start jupyter:

...adding core...
...adding mounts...
Bucket created successfully!
...starting jupyterlab...
ERROR: Failed to start jupyter server!

[ljlamarche]

I seem to be having the same issue as @pmreyes2 .

>>> Start bucket and jupyterlab? (y/n): y
...adding core...
...adding mounts...
Bucket created successfully!
...starting jupyterlab...
ERROR: Failed to start jupyter server!

I'll start digging into resen-core 2019.1.0rc2 and see if I can identify an issue.

[pmreyes2]

Everything working great. Tested on mac and linux.