Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other changes after cesm3_0_beta02 update #73

Merged
merged 11 commits into from
Sep 20, 2024

Conversation

gdicker1
Copy link
Contributor

@gdicker1 gdicker1 commented Sep 5, 2024

This is a PR to incorporate other changes to EarthWorks. These include things like performance timers and input file changes.

Please suggest any other changes you can think of!

NOTE: the code in this PR may not fetch cleanly until all Sub-PRs are merged and this PR is moved out of draft.

@gdicker1 gdicker1 added enhancement New feature or request external Has to do with externals EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream labels Sep 5, 2024
@gdicker1 gdicker1 self-assigned this Sep 5, 2024
@gdicker1 gdicker1 marked this pull request as ready for review September 14, 2024 01:31
@gdicker1
Copy link
Contributor Author

At this point I think everything is in place for this PR and the sub-PRs. If anyone wants to spot-check, that would be appreciated. I'll be running tests on this soon and hopefully merging before Derecho starts maintenance.

Adding @sherimickelson and @areanddee for the typical notify and @dazlich as an optional tester (his choice).

Tests that will use the ew-data_check testmod should be run with
'--no-setup' to keep the impact as light as possible. Since failure of
shell_commands during the CREATE_NEWCASE step are ignored, the success
of './check_input_data' is recorded in the ew_check_data.txt file.

A supplemental script is recommended to further automate this test.
The duplicates don't use the no_gw_front test mod. They are duplicated
so that comparisons against a previous tag can still be performed, and
future tags can compare against the new tests.
@gdicker1
Copy link
Contributor Author

gdicker1 commented Sep 19, 2024

Testing the ew-pr category using the code version in 091ec56 against runs of the same test category using the ew2.3.005 tag as baseline (results of #72 ) revealed:

All tests had failures when comparing current namelists (NLCOMP) and run outputs (DIFF) to the previous version. These were expected due to the change in input data.

At this point there is one other change I'd like to make to the tests, and this PR is ready to merge!

EDIT: I hadn't noticed that the CHAOS2000dev nvhpc test failed during the run with limited output but hit wallclock limit. I'm currently investigating before this is ready to merge again.

Since the MPAS-A input data has been updated, there's no longer a need
to turn of gravity wave frontogenesis with use_gw_front=.false. in the
atm namelist.
@gdicker1
Copy link
Contributor Author

The CHAOS2000dev nvhpc test ran successfully after re-submitting (no modifications). I think this was just a system glitch and not worth more thought.

Ready to merge again! I'm looking to do so at the end of the day (~5pm MT).

@sherimickelson @areanddee

Use tags for EarthWorksOrg/CAM EarthWorksOrg#33 and EarthWorksOrg/CTSM EarthWorksOrg#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream external Has to do with externals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant