Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cblockstate command #331

Open
wants to merge 4 commits into
base: fabric
Choose a base branch
from

Conversation

haykam821
Copy link
Collaborator

This pull request adds a command that lists the properties and their values of a specific block state.

/cblockstate minecraft:oak_slab

image

/cblockstate minecraft:oak_slab[type=top,waterlogged=true]

image

@Earthcomputer
Copy link
Owner

This PR needs updating after the fcapi merge

@haykam821 haykam821 requested a review from Earthcomputer June 10, 2022 20:44
source.sendFeedback(getPropertyLine(entry));
}

return 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 0;
return Command.SINGLE_SUCCESS;

Comment on lines +31 to +32
Identifier id = Registry.BLOCK.getId(state.getBlock());
String idStr = id == null ? "Unregistered" : id.toString();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id is never null.

@@ -0,0 +1,57 @@
package net.earthcomputer.clientcommands.command;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import order is a bit weird.

@xpple xpple added the enhancement New feature or request label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants