Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add connect four #655

Open
wants to merge 13 commits into
base: fabric
Choose a base branch
from
Open

add connect four #655

wants to merge 13 commits into from

Conversation

RealRTTV
Copy link
Contributor

@RealRTTV RealRTTV commented Aug 9, 2024

No description provided.

@RealRTTV RealRTTV marked this pull request as ready for review August 9, 2024 22:07
xpple
xpple requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have pushed a few style changes and have left the following comments.

src/main/java/net/earthcomputer/clientcommands/ClientCommands.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/TwoPlayerGameType.java Outdated Show resolved Hide resolved
src/main/resources/assets/clientcommands/lang/en_us.json Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/TwoPlayerGameType.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/FourInARowCommand.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/TwoPlayerGame.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/TwoPlayerGameType.java Outdated Show resolved Hide resolved
@RealRTTV @xpple
Update en_us.json
0eb97ee 
Co-authored-by: Frederik van der Els <49305700+xpple@users.noreply.github.com>
xpple
xpple requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good at a first glance. I did notice some translation keys still use fourInARowGame, could you change those as well?

@xpple
Copy link
Collaborator

xpple commented Sep 26, 2024

Perhaps you could now rename TwoPlayerGameType to just TwoPlayerGame.

@RealRTTV
Copy link
Contributor Author

no problem

@RealRTTV RealRTTV changed the title added connect four add connect four Sep 27, 2024
@RealRTTV RealRTTV requested a review from xpple September 27, 2024 00:59
@xpple xpple added the enhancement New feature or request label Sep 27, 2024
@RealRTTV RealRTTV requested a review from xpple September 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpple xpple Awaiting requested review from xpple

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealRTTV @xpple