Read input strings from stdin when none were given directly #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was very tricky to get right as I still wanted to have the nice clap error message about missing a required argument if there were no strings supplied via stdin or the normal arguments. See: - clap-rs/clap#3437 - clap-rs/clap#4539
github-actions
bot
added
the
dependencies
|
And for posterity, I did have to reference the rendering code to figure out the appropriate context information for the error kind I was using: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was very tricky to get right as I still wanted to have the nice clap error message about missing a required argument if there were no strings supplied via stdin or the normal arguments.
See:
Checklist
cargo xtask fixupfor formatting and lintingCHANGELOG.mdper "Keep a Changelog" format