Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/196 text changes overview monitoring #636

Merged
merged 3 commits into from
May 19, 2022

Conversation

maxdiebold-erg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Changed instances of Monitoring & Sensors on the Overview tab to Monitoring Locations.
  • Changed instances of Sample Locations on the Overview and Monitoring tabs to Past Water Conditions.
  • Put Location Name: in front of the monitoring location names in the accordions of the Overview and Monitoring tabs.

Steps To Test:

  1. Go to the Community page
  2. In the Overview tab, make sure the toggle and center sub-tab read Monitoring Locations
  3. In the center Monitoring Locations sub-tab, check that the second toggle reads Past Sample Locations, and that all accordion items start with Location Name:
  4. Similarly check the Monitoring tab

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@cschwinderg cschwinderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cschwinderg cschwinderg merged commit 9e76996 into develop May 19, 2022
@cschwinderg cschwinderg deleted the feature/196_text-changes-overview-monitoring branch May 19, 2022 12:05
cschwinderg added a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants