Skip to content

Commit

Permalink
Removed unused variables and arguments
Browse files Browse the repository at this point in the history
This fixes #177 #178 and #179
  • Loading branch information
javiereguiluz committed Mar 10, 2015
1 parent 32bb89d commit 684cb84
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions Configuration/Configurator.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class Configurator
{
private $backendConfig = array();
private $entitiesConfig = array();
private $doctrineManager;
private $reflector;
private $defaultEntityFields = array();

Expand Down Expand Up @@ -98,7 +97,7 @@ public function getEntityConfiguration($entityName)
$entityConfiguration['show']['fields'] = $this->getFieldsForShowAction($entityConfiguration);
$entityConfiguration['edit']['fields'] = $this->getFieldsForFormBasedActions('edit', $entityConfiguration);
$entityConfiguration['new']['fields'] = $this->getFieldsForFormBasedActions('new', $entityConfiguration);
$entityConfiguration['search']['fields'] = $this->getFieldsForSearchAction($entityConfiguration);
$entityConfiguration['search']['fields'] = $this->getFieldsForSearchAction();

$entityConfiguration = $this->introspectGettersAndSetters($entityConfiguration);

Expand Down Expand Up @@ -157,8 +156,6 @@ private function processEntityPropertiesMetadata(ClassMetadata $entityMetadata)
*/
private function getFieldsForListAction(array $entityConfiguration)
{
$entityFields = array();

// there is a custom configuration for 'list' fields
if (count($entityConfiguration['list']['fields']) > 0) {
return $this->normalizeFieldsConfiguration('list', $entityConfiguration);
Expand Down Expand Up @@ -209,10 +206,9 @@ protected function getFieldsForFormBasedActions($action, array $entityConfigurat
/**
* Returns the list of entity fields on which the search query is performed.
*
* @param array $entityConfiguration
* @return array The list of fields to use for the search
*/
private function getFieldsForSearchAction(array $entityConfiguration)
private function getFieldsForSearchAction()
{
$excludedFieldNames = array();
$excludedFieldTypes = array('association', 'binary', 'blob', 'date', 'datetime', 'datetimetz', 'guid', 'time', 'object');
Expand Down

0 comments on commit 684cb84

Please sign in to comment.