Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu item matcher does not work with pretty urls #6541

Closed
zorn-v opened this issue Nov 15, 2024 · 0 comments · Fixed by #6542
Closed

Menu item matcher does not work with pretty urls #6541

zorn-v opened this issue Nov 15, 2024 · 0 comments · Fixed by #6542

Comments

@zorn-v
Copy link
Contributor

zorn-v commented Nov 15, 2024

Describe the bug
When using pretty urls, current page in menu has link with just ? in href.
So item matcher never match it with current uri

To Reproduce
Just enable pretty urls and check active css class on current menu item
@zorn-v zorn-v mentioned this issue Nov 15, 2024
Merged
@alexislefebvre alexislefebvre mentioned this issue Nov 19, 2024
Closed
javiereguiluz added a commit that referenced this issue Nov 19, 2024
@javiereguiluz
bug #6542 Fix menu item matcher with pretty urls enabled (zorn-v)
d849b1e 
This PR was merged into the 4.x branch.

Discussion
----------

Fix menu item matcher with pretty urls enabled

Closes #6541

<!--
Thanks for your contribution! If you are proposing a new feature that is complex,
please open an issue first so we can discuss about it.

Note: all your contributions adhere implicitly to the MIT license
-->

Commits
-------

75b9a38 Fix menu item matcher
This was referenced Nov 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix menu item matcher with pretty urls enabled zorn-v/EasyAdminBundle
1 participant
@zorn-v