Introduced a new "design" global option #209
Conversation
by the new "design -> assets -> css" and "design -> assets -> js" options The deprecation should be transparent and all applications should keep working as previously. In addition, this commits splits the DI extension class into smaller and easier to manage sections.
javiereguiluz
force-pushed
the
new_design_global_option
branch
from
f18b3c7
to
f214971
Compare
| ->then(function ($v) { | ||
| // if the new option is defined, don't override it with the legacy option | ||
| if (!isset($v['design']['assets']['js'])) { | ||
| $v['design']['assets']['js'] = $v['assets']['js']; |
There was a problem hiding this comment.
Won't this (and other) instruction throw an error if the $v['design'] is not set yet ? 😕
There was a problem hiding this comment.
I've changed it here: 982f401 Let me know if it's better that way. Thanks.
|
👍 Everything sounds well to me |
|
|
||
| ->children() | ||
| ->variableNode('list_actions') | ||
| ->info('DEPRECATED: use the "actions" option of the "list" view.') |
There was a problem hiding this comment.
Shouldn't we throw some E_USER_DEPRECATED errors instead? Would it be too intrusive?
There was a problem hiding this comment.
Indeed I think it may be too intrusive.
|
@Pierstoval I'm leaving the |
|
Everything seems well, I think you can merge this ! The BC break convenience is really good ! |
This is the first issue related to #208