fix: use dashboardRoute when necessary #6553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
alexislefebvre
force-pushed
the
fix-use-dashboardRoute-when-necessary
branch
from
ad7bb96 to
e1aa3d7
Compare
javiereguiluz
added a commit
that referenced
this pull request
Nov 25, 2024
This PR was squashed before being merged into the 4.x branch. Discussion ---------- Fix an edge-case when using pretty URLs This is an alternative to #6553. Fixes #6550, #6535, #6498. `@alexislefebvre` thanks a lot for contributing that PR and also, thanks a lot for the failing test reproducer in #6559, which helped me a lot. Commits ------- eaa6a5b Fix an edge-case when using pretty URLs
|
Closing this in favor of #6567 ... but thanks a lot Alexis for this PR and for the reproducer that you also created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of the dashboard links, in my opinion they should not lead to an entity. Tests have been updated accordingly.
Fixes #6550:
The issue is reproducible on CI:
This is a different approach than the one used in #6551: