Update functions according to db refactoring #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use auto_site_name instead of set_site_arg Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
mrrobot47
requested changes
Aug 22, 2018
src/Shell_Command.php
Outdated
| $site_root = $db_select[0]['site_path']; | ||
| } else { | ||
|
|
||
| $site = Site::find( $site_name ); |
There was a problem hiding this comment.
Site::find is not a sufficient check. The site needs to be present as well as enabled otherwise the opening it's shell will not be possible. Create a model maybe Site::enabled that checks precisely both the things. It is required in almost all the commands.
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Site model instead of db calls
Use auto_site_name instead of set_site_arg
Signed-off-by: Kirtan Gajjar kirtangajjar95@gmail.com