Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JetBrains.Annotations dependency #107

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

Pliner
Copy link
Member

@Pliner Pliner commented Feb 7, 2019

No description provided.

Copy link
Member

@luigiberrettini luigiberrettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the attributes we do not use from Source/EasyNetQ.Management.Client/JetBrains/Annotations.cs

@Pliner Pliner merged commit f716510 into master Feb 8, 2019
@zidad
Copy link
Member

zidad commented Feb 8, 2019

@Pliner @luigiberrettini I think we should be able to include it as a nuget package, but mark all its assets as private: NuGet/Home#4125

@Pliner Pliner deleted the drop-jetbrains-annotations-dependency branch February 8, 2019 11:42
@luigiberrettini
Copy link
Member

Thanks @zidad, but isn't that useful for development dependencies only?

@zidad
Copy link
Member

zidad commented Feb 11, 2019

Yeah but I thought it was, from the nuget package: "All usages of ReSharper Annotations attributes are erased from metadata by default, which means no actual binary reference to 'JetBrains.Annotations.dll' assembly is produced. If you need to preserve these attributes in metadata, just define 'JETBRAINS_ANNOTATIONS' conditional compilation symbol in your projects."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants