phpstan #325
Merged
phpstan #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
approved these changes
Nov 30, 2023
I too am quite stoked |
jchen293
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces PHPStan which is a static analysis tool. Think of it like
mypyfrom Python but with additional tools built in for syntax checking in addition to type checking. This found SO many issues that needed fixing and will help enforce proper type hints.Testing
There are 3 additional levels of scrutiny we could use in this tool but it was getting overwhelming and I stopped here. There are some bigger changes needed to correct levels 7-9 so we'll revisit later.
Pull Request Type
Please select the option(s) that are relevant to this PR.