Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpusDecoder conflicts with opus library. #1967

Closed
mateofio opened this issue Dec 3, 2019 · 0 comments
Closed

OpusDecoder conflicts with opus library. #1967

mateofio opened this issue Dec 3, 2019 · 0 comments

Comments

@mateofio
Copy link
Contributor

mateofio commented Dec 3, 2019

Our OpusDecoder uses the same name as struct OpusDecoder on the system opus.h which can cause a conflict.

So far it seems benign, but we should fix it. The proper solution is to namespace everything.

Discovered by a warning on android build:

In file included from jni/src/../../../../../../..//src/audio_decoder.cpp:30:
jni/src/../../../../../../..//src/decoder_opus.h:29:1: warning: 'OpusDecoder' defined as a class here but previously declared as a struct [-Wmismatched-tags]
class OpusDecoder : public AudioDecoder {
^
/var/lib/jenkins/workspace/player-android-pr/../toolchain-android/android/armeabi-v7a-toolchain/include/opus/opus.h:399:9: note: did you mean class here?
typedef struct OpusDecoder OpusDecoder;
        ^~~~~~
        class
1 warning generated.
@Ghabry Ghabry added this to the 0.7.1 milestone Mar 8, 2023
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Mar 8, 2023
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Mar 8, 2023
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Mar 12, 2023
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants