You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our OpusDecoder uses the same name as struct OpusDecoder on the system opus.h which can cause a conflict.
So far it seems benign, but we should fix it. The proper solution is to namespace everything.
Discovered by a warning on android build:
In file included from jni/src/../../../../../../..//src/audio_decoder.cpp:30:
jni/src/../../../../../../..//src/decoder_opus.h:29:1: warning: 'OpusDecoder' defined as a class here but previously declared as a struct [-Wmismatched-tags]
class OpusDecoder : public AudioDecoder {
^
/var/lib/jenkins/workspace/player-android-pr/../toolchain-android/android/armeabi-v7a-toolchain/include/opus/opus.h:399:9: note: did you mean class here?
typedef struct OpusDecoder OpusDecoder;
^~~~~~
class
1 warning generated.
The text was updated successfully, but these errors were encountered:
Our OpusDecoder uses the same name as
struct OpusDecoder
on the systemopus.h
which can cause a conflict.So far it seems benign, but we should fix it. The proper solution is to namespace everything.
Discovered by a warning on android build:
The text was updated successfully, but these errors were encountered: