Windows: Support mpg123 1.28.1 and newer #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fixed Windows but breaks everything else 😊 |
With this release they added mpg123_ssize_t but this cannot be used because they forgot to bump MPG123_API_VERSION. Instead the underlying types were hardcoded.
Ghabry
force-pushed
the
windows/mpg123-fix
branch
from
fcdf5be to
2151812
Compare
|
Stupid: This is a breaking change but they did not bump Instead I hardcoded the underlying type. Similiar to the SDL2_Mixer solution: libsdl-org/SDL_mixer@ff4eac9 |
fdelapena
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, lets see what Jenkins says...