Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildscript for Windows no longer working ("Could NOT find inih") #176

Closed
florianessl opened this issue Apr 23, 2024 · 4 comments
Closed

Comments

@florianessl
Copy link
Member

I think this dependency was added just recently but I'm not yet familiar enough with the build process to fix this myself:

PS C:\Git\EasyRPG-Player-2> cmake --preset windows-x64-vs2022-debug -DPLAYER_BUILD_LIBLCF=ON
Preset CMake variables:

  ##toolchainFile="C:/Git/EasyRPG-Player-2/vcpkg/scripts/buildsystems/vcpkg.cmake"
  #toolchainFile="C:\Git\EasyRPG-buildscripts/windows/vcpkg/scripts/buildsystems/vcpkg.cmake"
  CMAKE_BUILD_TYPE="Debug"
  CMAKE_EXPORT_COMPILE_COMMANDS="ON"
  CMAKE_TOOLCHAIN_FILE:FILEPATH="C:\Git\EasyRPG-buildscripts/windows/vcpkg/scripts/buildsystems/vcpkg.cmake"
  VCPKG_TARGET_TRIPLET="x64-windows-static"

-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.22631.
-- Build type is set to Debug.
-- Found git info: 306 commits since tag "0.8", object hash is b313163f
-- Found SDL2: C:/Git/EasyRPG-buildscripts/windows/vcpkg/installed/x64-windows-static/share/sdl2 (SDL2::SDL2)
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.43.0.windows.1")
Cloning into 'C:/Git/EasyRPG-Player-2/lib/liblcf'...
CMake Error at C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find inih (missing: INIH_LIBRARY INIH_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  lib/liblcf/builds/cmake/Modules/Findinih.cmake:45 (find_package_handle_standard_args)
  C:/Git/EasyRPG-buildscripts/windows/vcpkg/scripts/buildsystems/vcpkg.cmake:852 (_find_package)
  lib/liblcf/CMakeLists.txt:345 (find_package)


-- Configuring incomplete, errors occurred!
@jetrotal
Copy link

Hi, I had the same problem. Seems to have been corrected on recent updates (at least on the player), check:
EasyRPG/Player#3207

this commit to be more specific:
EasyRPG/Player@13d7e27

@florianessl
Copy link
Member Author

florianessl commented Apr 23, 2024

Hm, weird... Everything is up to date (the GIT for this setup was checked out not more than 15 minutes ago...)
I'll double-check everything again..

@Ghabry
Copy link
Member

Ghabry commented Apr 23, 2024

Btw. If you want to save 2 hours of time use the precompiled libraries from Jenkins (download prebuilt script in windows folder)

Guess something is just outdated. Run that entire cmake command suffixed with --fresh.

@Ghabry
Copy link
Member

Ghabry commented Apr 26, 2024

closing this as works on Jenkins so cannot be broken ^^'

@Ghabry Ghabry closed this as completed Apr 26, 2024
@Ghabry Ghabry closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants