Windows: Fix touch input, disable window rounding #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Apr 11, 2024
On some devices the ID is not 0-4 but counts upwards. Introduced a new finger ID field to resolve this.
This looses pixels in the edges of the game. No error check. Will silently fail when unsupported.
carstene1ns
force-pushed
the
fix-touch-input
branch
from
9877d73 to
13d7e27
Compare
carstene1ns
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finger IDs sent seem to be different based on which device you use.
My Surface 4 sent 0 - 4 as ID. This Asus Laptop here increments the ID everytime. Removed the assumption from the code that the IDs are 0 - 4.
Disabled the window rounding on Win11 because its not nice when a few pixels of the game are simply lost...