Skip to content

MR - Subtitles rework + add broadcast #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 25, 2023
Merged

MR - Subtitles rework + add broadcast #38

merged 15 commits into from
Jul 25, 2023

Conversation

Mitix-EPI
Copy link
Contributor

Subtitles part

  • Subtitles are now a list of activated text fields
  • Subtitles can be added or removed
  • There is a little animation when you hover an activated text field
  • An activated field cannot be added a new time (filter)

Broadcast part

  • compressor
  • action reaction
  • subtitles

Mitix-EPI added 15 commits June 15, 2023 16:50
@Mitix-EPI
fix(broadcast): change check success statusCode
3672527
@Mitix-EPI
pending(broadcast): add .on & emitters
78500be 
fix statusCode 201 to 200
@Mitix-EPI
pending(broadcast): add areas update broadcast + prepare subtitles br…
8155165 
…oadcast
@Mitix-EPI
fix(broadcast socket): add boolean to make sure that the listenning i…
20e0098 
…s not multiplied
@Mitix-EPI
feat(socket): add getSubtitlesSettings & getAllTextFields
52e9adb
@Mitix-EPI
fix(): listener is destroyed after closing component
f0ce963
@Mitix-EPI
Merge branch 'main' into add-broadcast
335f11a
@Mitix-EPI
fix(compressor): align center
e925b68
@Mitix-EPI
rework(subtitles): list subtitles text fields
650ddf6 
* add subtitles text field
* remove subtitles text field
* broadcast
* ui/ux
@Mitix-EPI
fix merge conflict stah mescouilles
e90f3cd
@Mitix-EPI
Merge branch 'add-broadcast'
2dfe1c7 
Conflicts:
	src/Components/Subtitles/Subtitles.tsx
	src/Socket/interfaces.ts
@Mitix-EPI
fix(): merge error + change display text + avoid conflict variable name
239c907
@Mitix-EPI
fix(): empty subtitles handling
b6dacce
@Mitix-EPI
fix(): remove success notif + remove debug
a5ba848
@Mitix-EPI
fix(): text change -> easier to understand
6e9bc22
@Mitix-EPI Mitix-EPI merged commit 12f6e33 into main Jul 25, 2023
@Mitix-EPI Mitix-EPI deleted the rework-subtitles branch July 25, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mitix-EPI