fix: manually determine URLs for each notification type

Ebonsignori · Aug 1, 2022 · c3f6d82 · c3f6d82
1 parent 1c0a146
commit c3f6d82
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -221,17 +221,36 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const BASE = `https://github.com`;
 function determineUrl(core, octokit, inputs, notification) {
-    var _a;
+    var _a, _b;
     return __awaiter(this, void 0, void 0, function* () {
+        const urlResource = (_a = /[^/]*$/.exec(notification.subject.url)) === null || _a === void 0 ? void 0 : _a[0];
         if (notification.subject.type === "Discussion") {
             return `${BASE}/${notification.repository.full_name}/discussions?${encodeURI(notification.subject.title)}`;
         }
+        if (notification.subject.type === "Release") {
+            return `${BASE}/${notification.repository.full_name}/releases/tag/${notification.subject.title}`;
+        }
+        if (notification.subject.type === "Release") {
+            return `${BASE}/${notification.repository.full_name}/releases/tag/${notification.subject.title}`;
+        }
+        if (notification.subject.type === "PullRequest" && urlResource) {
+            return `${BASE}/${notification.repository.full_name}/pull/${urlResource}`;
+        }
+        if (notification.subject.type === "Issue" && urlResource) {
+            return `${BASE}/${notification.repository.full_name}/issues/${urlResource}`;
+        }
+        if (notification.subject.type === "CheckSuite") {
+            return `${BASE}/${notification.repository.full_name}/actions`;
+        }
+        if (notification.subject.type === "CheckSuite") {
+            return `${BASE}/${notification.repository.full_name}/actions`;
+        }
         // If no hard-coded method for fetching URL is defined, try .request to get the `html_url`
         let notificationHtmlURL;
         if (notification.subject.url) {
             try {
                 const notificationSubject = yield octokit.request(notification.subject.url);
-                notificationHtmlURL = (_a = notificationSubject === null || notificationSubject === void 0 ? void 0 : notificationSubject.data) === null || _a === void 0 ? void 0 : _a.html_url;
+                notificationHtmlURL = (_b = notificationSubject === null || notificationSubject === void 0 ? void 0 : notificationSubject.data) === null || _b === void 0 ? void 0 : _b.html_url;
                 // If there still isn't an html_url, it lives on another key
                 if (inputs.debugLogging && !notificationHtmlURL) {
                     core.warning(`Unable to find URL from linked api url for notification\nid :${notification.id}\nsubject:${JSON.stringify(notification.subject, null, 2)}\subject.url request: ${JSON.stringify(notificationSubject.data, null, 2)}`);

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -415,4 +415,4 @@ test("filters on filter-exclude-repositories", async (t) => {
 
 // TODO: Test rollup-notifications
 // TODO: Test timezone and date-format
-// TODO: Test html URLs
+// TODO: Test determined html URLs
diff --git a/src/lib/determine-url.ts b/src/lib/determine-url.ts
@@ -10,11 +10,42 @@ export default async function determineUrl(
   inputs,
   notification: Endpoints["GET /notifications"]["response"]["data"][0]
 ) {
+  const urlResource = /[^/]*$/.exec(notification.subject.url)?.[0];
   if (notification.subject.type === "Discussion") {
     return `${BASE}/${
       notification.repository.full_name
     }/discussions?${encodeURI(notification.subject.title)}`;
   }
+  if (notification.subject.type === "Release") {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/releases/tag/${notification.subject.title}`;
+  }
+  if (notification.subject.type === "Release") {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/releases/tag/${notification.subject.title}`;
+  }
+  if (notification.subject.type === "PullRequest" && urlResource) {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/pull/${urlResource}`
+  }
+  if (notification.subject.type === "Issue" && urlResource) {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/issues/${urlResource}`
+  }
+  if (notification.subject.type === "CheckSuite") {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/actions`
+  }
+  if (notification.subject.type === "CheckSuite") {
+    return `${BASE}/${
+      notification.repository.full_name
+    }/actions`
+  }
 
   // If no hard-coded method for fetching URL is defined, try .request to get the `html_url`
   let notificationHtmlURL;