Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Contributor Over Time graph #5351

Merged
merged 3 commits into from
Nov 9, 2021
Merged

docs: Add Contributor Over Time graph #5351

merged 3 commits into from
Nov 9, 2021

Conversation

juzhiyuan
Copy link
Contributor

What does this PR do?

This PR aims to add the Contributor Over Time to our repo.

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Followup

  • Check the output of Travis-CI for linter errors!

@eshellman
Copy link
Collaborator

  1. The preceding text probably should be changed , since we pass a thousand contributors a while ago.
  2. The graph is neat, but I prefer a link to it, not an embed. and maybe in the intro on README in stead of HOWTO

@davorpa davorpa added the New Feature New feature / enhancement / translation... label Sep 29, 2021
@davorpa davorpa changed the title docs: added Contributor Over Time docs: Add Contributor Over Time graph Nov 6, 2021
@davorpa davorpa added 👀 Needs Review Is this really a good resource? Reviews requested. stale Requests that have not had recent interaction (Out-of-Date) waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 6, 2021
@eshellman eshellman removed waiting for changes PR has been reviewed and changes/suggestions requested 👀 Needs Review Is this really a good resource? Reviews requested. stale Requests that have not had recent interaction (Out-of-Date) labels Nov 7, 2021
@eshellman eshellman requested a review from davorpa November 7, 2021 15:05
davorpa
davorpa reviewed Nov 7, 2021
View reviewed changes
HOWTO.md Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Contributor Author

Just noticed 😄 Will update this week.

davorpa
davorpa approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Nov 8, 2021
@eshellman eshellman merged commit c2f4a10 into EbookFoundation:master Nov 9, 2021
@juzhiyuan juzhiyuan deleted the patch-1 branch November 9, 2021 03:31
@davorpa davorpa mentioned this pull request Nov 28, 2021
Closed
39 tasks
@davorpa davorpa added 🗣️ locale:en Resources addressing "English" language 🗣️ translations Issues or PRs addresing translations labels Feb 18, 2022
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Feb 18, 2022
@davorpa
Add paragrah from EbookFoundation#5351. Need language translation
715a98d
@EbookFoundation EbookFoundation locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davorpa davorpa davorpa approved these changes

Assignees
No one assigned
Labels
New Feature New feature / enhancement / translation... 🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:en Resources addressing "English" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juzhiyuan @eshellman @davorpa