Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bangla free programming pdf book add #5979

Closed
wants to merge 1 commit into from

Conversation

Riyadh1734
Copy link

@Riyadh1734 Riyadh1734 commented Oct 6, 2021

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa
Copy link
Member

davorpa commented Oct 7, 2021

TIP 🚀: Thanks for taking your time on fill Pull Request fields in your first contribution ❤️

It's always a good practice which it use to increase the mantainers productivity.

Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, read the CONTRIBUTING guidelines with calm.

This request doesn't follow neither structure, I encourage you to take a look at other listings to understand how to are organized.


⚠️ Bad locale filename: Fix with ba (lowercase)

@vhf, the linter not supports this locale yet: https://github.com/vhf/free-programming-books-lint/blob/b72812e3cf51e0dce322a30d465f50ee618f3d0c/lib/lint.js#L18-L57

@davorpa davorpa added linter error Please, correct build errors found by linter! waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 7, 2021
@eshellman
Copy link
Collaborator

bengali books are in books/free-programming-books-bl.md

@Riyadh1734 Riyadh1734 removed their assignment Oct 7, 2021
@Riyadh1734 Riyadh1734 requested review from davorpa October 7, 2021 04:25
@Riyadh1734
Copy link
Author

bl does not stand for Bangla, it should be bn (iso standard). we are working contribution bn (Bangla) all the place.

Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would choose to add it to the list that Eric says and open an issue to propose this locale ISO code change.

There are other discussions about locales too. E.g:

@eshellman
Copy link
Collaborator

Have created #6021 to change language code. please restart from there - it should be merged within the hour.

@eshellman eshellman closed this Oct 7, 2021
@davorpa davorpa mentioned this pull request Oct 7, 2021
39 tasks
@davorpa davorpa added the 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter error Please, correct build errors found by linter! 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants