Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovenian language introduced #6176

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Slovenian language introduced #6176

merged 2 commits into from
Oct 12, 2021

Conversation

BlazOrazem
Copy link
Contributor

  • Slovenian language (sl) is introduced in HowTo section
  • a filename free-courses-sl.md is renamed to free-courses-si.md (because Sinhala language abbreviation is 'si' and not 'sl' which stands for Slovenian)

@davorpa
Copy link
Member

davorpa commented Oct 11, 2021

  • a filename free-courses-sl.md is renamed to free-courses-si.md (because Sinhala language abbreviation is 'si' and not 'sl' which stands for Slovenian)

You are right.

Fixes #5934

@davorpa davorpa added the New Feature New feature / enhancement / translation... label Oct 11, 2021
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Apply locale change in README.md too
    + [Sinhala / සිංහල](courses/free-courses-sl.md)
  • I dont know if i would be better leave free-programming-books text as-is

HOWTO-sl.md Outdated

Tudi če ste izkušeni na področju programiranja odprte kode, se bodo zagotovo našle zadeve, ki vas lahko malce zaustavijo. Ko oddate PR, bo GitHub Actions zagnal pregledovalnik, ki pogosto najde manjše težave z razmikom ali abecedo. Če se vam prikaže zeleni gumb, je vse pripravljeno za pregled. Če se zeleni gumb ne prikaže, kliknite »Podrobnosti« pod kljukico, ki je ugotovila, kaj pregledovalniku ni bilo všeč. Odpravite težavo in dodajte zahtevo (commit) v PR.

Če niste prepričani, da je vir, ki ga želite dodati, primeren za zbirko brezplačnih knjig o programiranju, preberite smernice v [CONTRIBUTING] (CONTRIBUTING.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix markdown syntax for hyperlinks.

Suggested change
Če niste prepričani, da je vir, ki ga želite dodati, primeren za zbirko brezplačnih knjig o programiranju, preberite smernice v [CONTRIBUTING] (CONTRIBUTING.md).
Če niste prepričani, da je vir, ki ga želite dodati, primeren za zbirko brezplačnih knjig o programiranju, preberite smernice v [CONTRIBUTING](CONTRIBUTING.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed Readme too and I agree - it's better to leave free-programming-books text as-is - fixed that too :)

@davorpa davorpa added question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 11, 2021
@davorpa davorpa mentioned this pull request Oct 11, 2021
39 tasks
@davorpa davorpa self-requested a review October 11, 2021 21:05
@davorpa davorpa removed question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 11, 2021
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Oct 11, 2021
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 7b8413a into EbookFoundation:master Oct 12, 2021
@davorpa davorpa added the 🗣️ translations Issues or PRs addresing translations label Feb 11, 2022
@davorpa davorpa added 🗣️ locale:sl Resources addressing "Slovenian / slovenščina" language 🗣️ locale:si Resources addressing "Sinhala / සිංහල" language labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature / enhancement / translation... 🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:si Resources addressing "Sinhala / සිංහල" language 🗣️ locale:sl Resources addressing "Slovenian / slovenščina" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants