Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add books in Latvian #6979

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Add books in Latvian #6979

merged 2 commits into from
Aug 3, 2022

Conversation

tgrants
Copy link
Contributor

@tgrants tgrants commented Jul 30, 2022 •
edited
Loading

What does this PR do?

Add resource(s)

For resources

Description

Added 2 books in Latvian by Jānis Zuters

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa
Copy link
Member

davorpa commented Jul 31, 2022 •
edited
Loading

Nice!

The new file locale is right: https://www.localeplanet.com/icu/lv/index.html

@davorpa davorpa added the 🗣️ locale:lv Resources addressing "Latvian / Lettish" language label Jul 31, 2022
davorpa
davorpa requested changes Jul 31, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs register this new file at README.md

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Jul 31, 2022
@tgrants tgrants requested a review from davorpa July 31, 2022 15:26
davorpa
davorpa approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enough now 🚀

@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Jul 31, 2022
@davorpa davorpa mentioned this pull request Jul 31, 2022
Closed
39 tasks
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books! We just need Lithuanian to have the Baltics covered. (I was in Estonia when this PR was submitted)

@eshellman eshellman merged commit ad4ef13 into EbookFoundation:main Aug 3, 2022
@davorpa davorpa mentioned this pull request Sep 1, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorpa davorpa davorpa approved these changes

Assignees

@tgrants tgrants

Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:lv Resources addressing "Latvian / Lettish" language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgrants @davorpa @eshellman