Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #3

Merged
merged 10 commits into from
Feb 25, 2023
Merged

Footer #3

merged 10 commits into from
Feb 25, 2023

Conversation

Vivek-68
Copy link
Contributor

ADD: Footer and Contact Section

@JOSU9435
Copy link
Collaborator

changes Required:

  • move fonts from the components dir to the public dir

Copy link
Collaborator

@codadept codadept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the above changes do the following

  1. Remove unnecessary images (remove all the .jpg files) like 210000.jpg etc from the gilroy fonts.

  2. Any colours you have used should be used from the global variables declared in index.scss

e.g. There is a color variable with name --srijan4-dark-blue and to use it in your scss use

color: var(--srijan4-dark-blue);

And also once you have moved the font to public/fonts/gilroy import the font in the index.scss at the top and declare a variable with name --srijan4-font-2 and remove the import in your Footer's scss and use it as a variable

font-family: var(--srijan4-font-1), sans-serif;

Remember to always use a fallback font whenever you use an imported font

src/App.jsx Outdated Show resolved Hide resolved
src/Components/Footer/Footer.jsx Outdated Show resolved Hide resolved
src/Components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/Components/Footer/Footer.jsx Outdated Show resolved Hide resolved
@codadept codadept added the wip Work in Progress label Feb 24, 2023
@codadept codadept linked an issue Feb 24, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for srijan-2023 ready!

Name Link
🔨 Latest commit c4f0bc3
🔍 Latest deploy log https://app.netlify.com/sites/srijan-2023/deploys/63fa1ed1aee08200080134f1
😎 Deploy Preview https://deploy-preview-3--srijan-2023.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Vivek-68 Vivek-68 requested a review from codadept February 24, 2023 20:06
Copy link
Collaborator

@codadept codadept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly execute the following commands

git checkout dev

pnpm install
pnpm pretty

# If there are any changes then commit those changes
git add .
git commit -m "FIX: Pretty code"

git checkout Footer
git merge dev

And then continue with the fixes I told today

src/Components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
@codadept codadept merged commit f2140f7 into Ecell-NITS:dev Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer Section
4 participants