-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer #3
Footer #3
Conversation
changes Required:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the above changes do the following
-
Remove unnecessary images (remove all the .jpg files) like 210000.jpg etc from the gilroy fonts.
-
Any colours you have used should be used from the global variables declared in index.scss
e.g. There is a color variable with name --srijan4-dark-blue and to use it in your scss use
color: var(--srijan4-dark-blue);
And also once you have moved the font to public/fonts/gilroy
import the font in the index.scss at the top and declare a variable with name --srijan4-font-2 and remove the import in your Footer's scss and use it as a variable
font-family: var(--srijan4-font-1), sans-serif;
Remember to always use a fallback font whenever you use an imported font
✅ Deploy Preview for srijan-2023 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly execute the following commands
git checkout dev
pnpm install
pnpm pretty
# If there are any changes then commit those changes
git add .
git commit -m "FIX: Pretty code"
git checkout Footer
git merge dev
And then continue with the fixes I told today
ADD: Footer and Contact Section