Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Details Page #36

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Events Details Page #36

wants to merge 10 commits into from

Conversation

31adityakumar
Copy link
Contributor

No description provided.

@31adityakumar 31adityakumar added wip Work in Progress don't merge labels Mar 2, 2023
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for srijan-2023 ready!

Name Link
🔨 Latest commit 8192bdf
🔍 Latest deploy log https://app.netlify.com/sites/srijan-2023/deploys/64427ddc7c60dd00083e4b91
😎 Deploy Preview https://deploy-preview-36--srijan-2023.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codadept
codadept reviewed Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@codadept codadept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you added react-helmet, you haven't used it anywhere.

codadept
codadept requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@codadept codadept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Changes:

  1. Make use of the same json file for displaying the event in the page as well as the Event Cards in Home Page as well as Event Page

src/Pages/EventPage/EventPage.jsx Outdated Show resolved Hide resolved
src/Components/Event/Event.jsx Outdated Show resolved Hide resolved
src/Components/Event/Event.jsx Outdated Show resolved Hide resolved
src/Components/Event/Event.jsx Outdated Show resolved Hide resolved
src/Components/Event/Event.jsx Outdated Show resolved Hide resolved
src/Components/Event/Event.jsx Outdated Show resolved Hide resolved
@codadept codadept linked an issue Mar 4, 2023 that may be closed by this pull request
Event Page #16
Open
@31adityakumar 31adityakumar added pls-merge Please review and/or merge this PR and removed wip Work in Progress don't merge labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codadept codadept Awaiting requested review from codadept

@JOSU9435 JOSU9435 Awaiting requested review from JOSU9435

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pls-merge Please review and/or merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Page
2 participants
@31adityakumar @codadept