Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/configs #158

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Fix/configs #158

merged 8 commits into from
Nov 24, 2023

Conversation

belerico
Copy link
Member

Summary

In this PR we have moved the following config fields:

  • total_steps, per_rank_batch_size, per_rank_sequence_length and both the cnn_keys and mlp_keys to the algo config

Type of Change

Please select the one relevant option below:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

sheeprl/algos/p2e_dv1/p2e_dv1_finetuning.py Outdated Show resolved Hide resolved
howto/select_observations.md Show resolved Hide resolved
howto/select_observations.md Show resolved Hide resolved
howto/select_observations.md Show resolved Hide resolved
@belerico belerico merged commit ad59960 into main Nov 24, 2023
10 checks passed
@michele-milesi michele-milesi deleted the fix/configs branch December 15, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants