Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: observation normalization #214

Merged
merged 6 commits into from
Feb 26, 2024
Merged

fix: observation normalization #214

merged 6 commits into from
Feb 26, 2024

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Subtract -0.5 to the normalized observation before cnn forward in dreamer_v3

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

belerico
belerico previously approved these changes Feb 26, 2024
DavideTr8
DavideTr8 previously approved these changes Feb 26, 2024
@michele-milesi michele-milesi dismissed stale reviews from DavideTr8 and belerico via c3a4537 February 26, 2024 10:22
@belerico belerico self-requested a review February 26, 2024 10:26
@belerico belerico merged commit 233e79b into main Feb 26, 2024
10 checks passed
@belerico belerico deleted the fix/dreamer_v3_cnn_encoder branch February 26, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants