Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replay ratio #247

Merged
merged 38 commits into from
Mar 29, 2024
Merged

Feature/replay ratio #247

merged 38 commits into from
Mar 29, 2024

Conversation

belerico
Copy link
Member

Summary

This PR introduces the replay_ratio as specified in #223. In particular we have removed both the per_rank_gradient_steps and train_every, since those two can be computed with the single output from the newly introduced Ratio class. We have also modified how the Dreamer-V1 family algos compute the exploration actions, while removing that from Dreamer-V2 and Dreamer-V3 since those are unused by those algos.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.

Additional Information (Optional)

Please provide any additional information that may be useful for the reviewer, such as:

  • Any potential risks or challenges associated with the changes.
  • Any instructions for testing or running the code.
  • Any other relevant information.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

belerico and others added 30 commits February 8, 2024 09:07
ratio.py Outdated Show resolved Hide resolved
sheeprl/algos/dreamer_v1/dreamer_v1.py Show resolved Hide resolved
sheeprl/algos/dreamer_v1/utils.py Show resolved Hide resolved
sheeprl/configs/algo/dreamer_v2.yaml Outdated Show resolved Hide resolved
michele-milesi
michele-milesi previously approved these changes Mar 29, 2024
@belerico belerico merged commit 3dc227b into main Mar 29, 2024
10 checks passed
@belerico belerico deleted the feature/replay-ratio branch March 30, 2024 17:35
@belerico belerico linked an issue Apr 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Hafner train_ratio and general replay_ratio
2 participants